lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: use Environment.TickCount instead DateTime...
Date Sat, 16 May 2015 17:57:04 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/145

    use Environment.TickCount instead DateTime.Now.Millisecond

    During the port System.currentTimeMillis was translated to System.DateTime.Now.Millisecond
which are not equivalent. This introduced long running tests that can be seen in several places
in Lucene.Net (e.g. TestTransactions.TestTransactions_Mem). When used to determine how long
to run a certain operation, in certain cases this bug was equivalent of running the test infinitely
(or a very very long time). See changes to TestTransactions.cs that illustrate the problem
well.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet timing_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #145
    
----
commit ee1635f4c12385f9310fef75078d0c9e13fda966
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-05-16T17:49:49Z

    use Environment.TickCount instead DateTime.Now.Millisecond

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message