lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Stallcontrol fix
Date Fri, 08 May 2015 18:46:36 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/142

    Stallcontrol fix

    TestDocumentsWriterStallControl fails in Release mode but not in Debug builds. Looks like
Lucene is performing logic when calling assert, which translated to Debug.Assert in Lucene.Net.
Debug.Assert is removed at the compile time if compiled in release mode.
    
    Took out the logic from the Debug.Assert.
    
    Here is the failing test that this fixes:
    http://teamcity.codebetter.com/viewLog.html?buildId=190748&tab=buildResultsDiv&buildTypeId=LuceneNet_Core#testNameId-5834889155160949386
    
    There are more places in the code base that suffer from this, I believe. Looking for them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet stallcontrol_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #142
    
----
commit e7381c089e15bf363bcc2e962aa15604c139726e
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-05-08T18:42:05Z

    don't perform logic in Debug.Assert

commit 4eab349bbbe456873d79b6c0e3442be51bdca3c6
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-05-08T18:43:25Z

    fix spelling mistake

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message