lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: use proper random.next
Date Tue, 05 May 2015 01:52:20 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/140

    use proper random.next

    Occasionally tests TestConcurrentReads fail with expected hit 1 but getting back 0. The
issue is that the field values being added to the document are 0 to numDocs - 1 and the random
queries are generated using 0 to numDocs. So if random hits the numDocs value, that document
is not in the index and test fails. Adjusted test to match what Lucene is doing:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/test-framework/src/java/org/apache/lucene/index/BaseStoredFieldsFormatTestCase.java#L439

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet nextrand_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #140
    
----
commit b22388e19134b1d263cf3aa702f63e7f35a62d8f
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-05-05T01:50:00Z

    use proper random.next

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message