lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Make sure offsetGap is nullable int
Date Sun, 03 May 2015 22:04:26 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/138

    Make sure offsetGap is nullable int

    When MockAnalyzer is used, in certain cases the index could have incorrect values written
to it. GetOffsetGap does a comparison of OffsetGap_Renamed to null which is always false if
OffsetGap_Renamed is not nullable int. Corrected the logic.
    
    To see the bug in action, refer to the following failing test:
    
    http://teamcity.codebetter.com/viewLog.html?buildId=190073&tab=buildResultsDiv&buildTypeId=LuceneNet_Core#testNameId778192460553334183


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet mockanalyzer_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/138.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #138
    
----
commit 9f5fa011ca5a8ef58a84c50b43d639751120a136
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-05-03T21:59:54Z

    make sure offsetGap is nullable int

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message