lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet pull request: use GetSafe instead of Get to match java b...
Date Sat, 02 May 2015 17:28:12 GMT
Github user synhershko commented on the pull request:

    https://github.com/apache/lucenenet/pull/136#issuecomment-98381539
  
    I would go ahead and fix all those occurrences, at least the ones that in the matching
Java code are expected not to throw. Note in `Lucene.Net.Support.BitSetSupport` we have several
other extension methods (SafeSet etc), all provide support around BitArray usage to mimic
Java's BitSet API.
    
    The reason why I think we should make sure all calls to BitArray is because otherwise
we are sure our port is wrong (throws while the Java code does not), and even though we have
randomized tests we are still not necessarily covering all code paths (or haven't yet had
enough test runs).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message