lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Fix SkipBytes in the reverse reader
Date Thu, 30 Apr 2015 18:40:12 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/134

    Fix SkipBytes in the reverse reader

    Lucene42 tests were passing but still showing assert failures occasionally with Fail:
frozenHash=xxxxx vs h=xxxx" messages. SkipBytes had a bug where Position value was being read
from BytesStore (outer instance) and not using reverse reader logic. Here is the method in
Lucene:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/util/fst/BytesStore.java#L434

    
    The other commit was to eliminate assert messages showing up that were actually not valid
failures. There was a bug where Pending.Size() was used instead of PendingCounts.Size() call,
as Lucene is doing:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java#L284

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet bytesstorefix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #134
    
----
commit 465f7b9fda5d1d3b403d1d3fd96270a5dea6d943
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-04-30T18:32:25Z

    fix skip bytes implementation

commit 27be98ab3c45343bc31761fe25d3845220319580
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-04-30T18:32:54Z

    fix assert logic

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message