lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: use CompareOrdinal vs CompareTo
Date Sun, 26 Apr 2015 17:33:16 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/133

    use CompareOrdinal vs CompareTo

    TestIndexableBinaryStringTools.TestEncodedSortability is failing because of the comparison
method that C# port was using. Just to make sure, captured a few failing test case data and
reran the same data in Lucene test and the values generated by C# port match what Lucene generates.
The bug was in the test that did comparison, Java calls CompareTo which appears to be equivalent
to C# string's CompareOrdinal call.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet indexablebinarystringtools_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #133
    
----
commit b692fc0d8156517b7625a37be7ffa3dce2a1c050
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-04-26T17:30:33Z

    use CompareOrdinal vs CompareTo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message