lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: change how TopTermsRewrite instance of is ...
Date Wed, 22 Apr 2015 00:49:13 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/130

    change how TopTermsRewrite instance of is checked

    Changing the logic that checks if rewrite method is an instance of some sort of TopTermsRewrite
to match Lucene. Key change is here:
    
    https://github.com/apache/lucenenet/compare/master...laimis:fuzzyquery_fix?expand=1#diff-605c6558db33049a7e4d93482e5432aeL67
    
    Instead of checking for TopTermsRewrite<Q>, it seems like Lucene cares only if it
is TopTermsRewrite based class but does not care what parameter type is used and it does not
need to match SpanMultiTermQueryWrapper parameter type:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/search/spans/SpanMultiTermQueryWrapper.java#L68
    
    At least that's how interpreted it. The tests seem to pass and this also fixes failing
test in TestSpanMultiTermQueryWrapper. TestFuzzy2

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet fuzzyquery_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #130
    
----
commit d021a5228de4a35e82c96ad45266ec5a520d7e0f
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-04-22T00:43:04Z

    change how TopTermsRewrite instance of is checked

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message