lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: LineFileDocs fix
Date Sat, 07 Mar 2015 19:09:59 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/124

    LineFileDocs fix

    Test helper class LineFileDocs generates test documents with the smallest id set to 1
instead of 0. Tests that expected docId:0 to be in the index failed as a result. Changed the
implementation to get the value of id first and then increment, which matches what Lucene
is doing:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/test-framework/src/java/org/apache/lucene/util/LineFileDocs.java#L237
    
    With the fix TestNRTThreads.TestNRTThreads_Mem and TestSearcherManager.TestSearcherManager_Mem
now pass. Here are the failures in TC:
    
    http://teamcity.codebetter.com/viewLog.html?buildId=185350&tab=buildResultsDiv&buildTypeId=LuceneNet_Core#testNameId5653300530033422727
    
    http://teamcity.codebetter.com/viewLog.html?buildId=185350&tab=buildResultsDiv&buildTypeId=LuceneNet_Core#testNameId1102378654731360526


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet LineDocs_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #124
    
----
commit 80bcdfaf19e1f6708007c3c6c885f61a44e0355a
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-03-07T19:05:08Z

    make sure ids start with 0 and not 1

commit 6bbe71ffe4b450a830097adb137adb6fb4c76196
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-03-07T19:05:33Z

    output deleted ids for easier debugging

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message