lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: match Lucene logic of not creating the dir...
Date Sun, 01 Mar 2015 18:22:54 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/117

    match Lucene logic of not creating the directory

    There is still discussion going on about what to do with FSDirectory's GetCanonicalPath:
https://github.com/apache/lucenenet/pull/70 @synhershko  has assigned this to himself to investigate.
While he is doing that, this PR removes the offending code so that we match Lucene's behavior
in that we don't create the directory if it does not exist. The failing tests related to this,
TestIndexWriter.TestNoDocs and TestMultiPhraseQuery now pass.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet fsdirectory_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #117
    
----
commit 46b3b794dca8a035e7c751574b931449c5502316
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-03-01T18:13:40Z

    match Lucene logic of not creating the directory first

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message