lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Fix for TestDirectoryReaderReopen.TestThre...
Date Sun, 01 Mar 2015 22:31:08 GMT
Github user synhershko commented on the pull request:

    https://github.com/apache/lucenenet/pull/112#issuecomment-76635291
  
    Ok just reviewed it - this class has only 2 usages and the fix looks legit enough...
    
    I moved class using it to the TestFramework project; the other only usage warrant making
`WeakIdentityMap` internal but we'll get to it when we are done by setting up `InternalsVisibleTo`
properly for the test projects


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message