lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chand2048 <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Fix for TestIndexableField.TestArbitraryFi...
Date Wed, 11 Feb 2015 18:16:07 GMT
GitHub user Chand2048 opened a pull request:

    https://github.com/apache/lucenenet/pull/96

    Fix for TestIndexableField.TestArbitraryFields - In java, the byte class...

    ... is signed and in C# it is unsigned. Changed the unit test to cast to a (byte) insetad
of an (sbyte).
    
    An alternate much deeper fix would be to change the Lucene.Net.Util.BytesRef class to
use sbyte insetad of byte. Not sure if this class was intentionally setup this way or if it
is a conversion error. Comments please.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guidotag/lucenenet Chand7

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #96
    
----
commit 7b2b53e40272140e488ebdfcb18b45b4a0f8d88d
Author: Chand2048 <chand@microsoft.com>
Date:   2015-02-11T18:14:46Z

    Fix for TestIndexableField.TestArbitraryFields - In java, the byte class is signed and
in C# it is unsigned. Changed the unit test to cast to a (byte) insetad of an (sbyte).
    
    An alternate much deeper fix would be to change the Lucene.Net.Util.BytesRef class to
use sbyte insetad of byte. Not sure if this class was intentionally setup this way or if it
is a conversion error. Comments please.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message