lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Index fixes
Date Mon, 09 Feb 2015 01:12:56 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/89

    Index fixes

    This PR marks several IncrementToken methods as sealed that allow some tests to pass.
Also contains fixes for TestIndexWriterReader where "ShouldFail" flag was totally ignored
and exception were simulated at the times when tests did not expect it. The same with TestIndexWriterExceptions.

    
    TestIndexWriterExceptions has an additional fix where tests handled generic exception
as an "unexpected" exception and treated "CorruptIndexException" as the expected type That
does not match the Lucene version:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions.java#L185
    
    Fixed that and used a more explicit exception type to make sure that we are handling only
the expected exception and nothing else.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet index_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #89
    
----
commit 830932a9de67e9cb1a08a17c52969a59f77d8da4
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-02-09T01:02:16Z

    match Lucene logic and mark IncrementToken as sealed

commit 150651bc1be9d5a25f1b87881db0083cc4ea3ea4
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-02-09T01:12:27Z

    mark as sealed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message