lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Set lock factory directly and not through ...
Date Fri, 06 Feb 2015 00:35:19 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/76

    Set lock factory directly and not through setter

    FaultyFSDirectory was using a setter to set lock factory when it should have assigned
directly to a class variable. Using a setter executes logic that should have never been run.

    
    Lucene is not using setLockFactory there:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/test/org/apache/lucene/index/TestFieldsReader.java#L113
    
    This fixes failure in TestFieldsReader.TestExceptions

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet faultyfsdirectory_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/76.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #76
    
----
commit 77160d7420538130458cdd767245005a86a75331
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-02-06T00:32:53Z

    set lock factory directly and not through setter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message