lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: preserve exception type
Date Thu, 05 Feb 2015 19:19:17 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/75

    preserve exception type

    Fix port implementation of "FillOpenTrace" to preserve the exception type that was intended
to be thrown. In addition, rename the method to reflect better what it does in .NET as in
Java version it would modify the stack trace of the exception but .NET version is instead
passing the original exception as inner exception.
    
    This fixes tests that depend on IOException being thrown and not Exception, such as Lucene.Net.Index.TestCodecHoldsOpenFiles.TestExposeUnclosedFiles

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet mockdirectorywrapper_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #75
    
----
commit 74deb0d4182ad1e993f60eb4458508cb94255df1
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-02-05T19:15:57Z

    preserve exception type

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message