lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Don't modify the collection while iteratin...
Date Wed, 04 Feb 2015 21:36:23 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/74

    Don't modify the collection while iterating over it

    Collection was being modified while iterated, which throws an exception in .NET. I am
not 100% sure if try / finally is necessary but the comment was suggesting to do it as such.
@synhershko any thoughts on this one? Is the idea here that we want to remove the ones that
were successfully iterated over before the exception occurred?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet documentswriter_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #74
    
----
commit f25c3c1a85f45ff64722f7d921f42c538b4b165d
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-02-04T21:29:54Z

    don't modify while iterating over a collection

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message