lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: replace dictionary with hashmap to support...
Date Wed, 04 Feb 2015 01:52:13 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/73

    replace dictionary with hashmap to support null keys

    Replace Dictionary with HashMap for tracking SegmentsToMerge in the IndexWriter. Lucene
is using HashMap, and I can confirm by running Lucene 4.8 tests that sometimes there are cases
when IndexWriter will insert null value as key. It is happening here:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java#L1788
    
    When instance of OneMerge is created and passed around there is no guarantee that segment
info will be set.
    
    This now passes TestAddIndexesWithThreads and TestAddIndexesWithRollback in Lucene.Net.Index.TestAddIndexes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet indexwriter_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #73
    
----
commit dc371cc54c4b468acd27252d961ac920d7743f1c
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-02-04T01:43:57Z

    replace dictionary with hashmap to support null keys

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message