lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <>
Subject [GitHub] lucenenet pull request: Support negative numbers in Lucene40 codec
Date Sun, 01 Feb 2015 11:38:13 GMT
GitHub user laimis opened a pull request:

    Support negative numbers in Lucene40 codec

    Lucene40 codec picks different methods of storing numeric values based on what data type
is large enough to represent them. The issue was with the numbers that can fit in sbyte, they
were being returned as byte due to our migration. Negative numbers -128 or greater were being
returned as positive numbers.
    This passes all remaining failing Lucene40 codec tests. Here is one example:
    Test expects to get back -10 but is getting back 246 instead.

You can merge this pull request into a Git repository by running:

    $ git pull lucene40docvaluesreader_fix

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #67
commit f300a4de6efbedd709b44f1b42a358398fbfd1cb
Author: Laimonas Simutis <>
Date:   2015-02-01T11:26:09Z

    support negative numbers


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message