lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: fix enumerators to use appropriate logic
Date Sun, 01 Feb 2015 01:07:09 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/66

    fix enumerators to use appropriate logic

    When merging segments with sorted or sortedset values, incorrect data was written to the
index:
    
    - GetMergeSortValuesEnumerable was ignoring ordinal value of -1. Here is Lucene code for
the same iterator: https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/codecs/DocValuesConsumer.java#L390
    
    - GetMergeSortedSetValuesEnumerable was skipping one value. Here is the relevant part
in Lucene: https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/codecs/DocValuesConsumer.java#L583
    
    Lucene45, Lucene41, and Perfield codecs are now all green with a few runs that I did locally.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet docvaluesconsumer_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #66
    
----
commit 26ebf9eafc945ff7dbfd8275771badce487902b9
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-02-01T01:01:02Z

    fix enumerators to use appropriate logic

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message