lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chand2048 <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Fix for TestIndexReaderClose.TestCloseUnde...
Date Wed, 25 Feb 2015 22:34:48 GMT
GitHub user Chand2048 opened a pull request:

    https://github.com/apache/lucenenet/pull/113

    Fix for TestIndexReaderClose.TestCloseUnderException

    The IndexReader.NotifyReaderClosedListeners() did not properly suppress the exceptions
thrown from the call to listener.OnClose(). Unfortunately there is no place to track the suppressed
exception so it is just dropped.
    Changing to return AggregateException will change the type and cause problems later for
flow control.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guidotag/lucenenet TestCloseUnderException2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #113
    
----
commit 3460f52fefefbf16c0577a8068c1887d82fb449e
Author: Chand2048 <chand@microsoft.com>
Date:   2015-02-25T22:34:14Z

    Fix for TestIndexReaderClose.TestCloseUnderException
    
    The IndexReader.NotifyReaderClosedListeners() did not properly suppress the exceptions
thrown from the call to listener.OnClose(). Unfortunately there is no place to track the suppressed
exception so it is just dropped.
    Changing to return AggregateException will change the type and cause problems later for
flow control.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message