lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chand2048 <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Fix for TestThreadInterruptDeadlock
Date Wed, 25 Feb 2015 19:27:22 GMT
GitHub user Chand2048 opened a pull request:

    https://github.com/apache/lucenenet/pull/111

    Fix for TestThreadInterruptDeadlock

    Use the C# ThreadInterruptedException so the catches will properly control the flow during
interruption.
    This fixes the two unit tests Lucene.Next.Index.TestIndexWriter.TestThreadInterruptDeadlock
and Lucene.Next.Index.TestIndexWriter.TestTwoThreadsInterruptDeadlock
    Lucene uses the ThreadInterruptedException for code flow control so it is important to
use the C# ThreadInterruptedException to avoid duplicating the catch everywhere and preserve
the flow.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guidotag/lucenenet TestThreadInterruptDeadlock2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #111
    
----
commit 9769e6d5d1c35fc4f7095450bef24fd452caa53f
Author: Chand2048 <chand@microsoft.com>
Date:   2015-02-25T19:26:29Z

    Fix for TestThreadInterruptDeadlock
    
    Use the C# ThreadInterruptedException so the catches will properly control the flow during
interruption.
    This fixes the two unit tests Lucene.Next.Index.TestIndexWriter.TestThreadInterruptDeadlock
and Lucene.Next.Index.TestIndexWriter.TestTwoThreadsInterruptDeadlock
    Lucene uses the ThreadInterruptedException for code flow control so it is important to
use the C# ThreadInterruptedException to avoid duplicating the catch everywhere and preserve
the flow.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message