lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: don't convert to sbyte
Date Wed, 25 Feb 2015 02:10:29 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/110

    don't convert to sbyte

    This fixes TestLongLiterals for Codec.Compressing.TestFastCompressionMode and TestFastDecompressionMode
tests. sbyte cast changed comparison logic where compressed[off] evaluated to 255.
    
    Example failure on TC: http://teamcity.codebetter.com/viewLog.html?buildId=182801&tab=buildResultsDiv&buildTypeId=LuceneNet_Core#testNameId-5764249506196176847


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet compression_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #110
    
----
commit 5401ade2f6fb6e8d8aee4b8c8f86c2ac824c75e2
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-02-25T02:05:48Z

    don't convert to sbyte

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message