lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <>
Subject [GitHub] lucenenet pull request: Index test fixes
Date Sun, 22 Feb 2015 16:30:12 GMT
GitHub user laimis opened a pull request:

    Index test fixes

    TestIndexWriterExceptions was failing because deletes were not reflected when the index
was opened with the reader. The reason for that was that the documents were being sent with
leading 0 in the id (e.g. "id:01" instead of "id:1") but deletes were executed against id
without leading zero. Simple oversight of .NET port, Lucene adds the base and i first before
converting to string.
    TestParallelCompositeReader needed to be adjusted to match ported code that uses anonymous
inner class helper so the type name is different.

You can merge this pull request into a Git repository by running:

    $ git pull index_test_fixes

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #108
commit 75e5a1581f3eff90aea5ebc1e1c5d12b438bfb33
Author: Laimonas Simutis <>
Date:   2015-02-22T16:22:17Z

    make sure base is not appended as char

commit 3c2ba5408169a37cc3775dcd7ca85c1aff8ca2cf
Author: Laimonas Simutis <>
Date:   2015-02-22T16:23:03Z

    adjust test to match Lucene.Net usage of anonymous classes

commit e8b23498b841daf6192763d51b1c9fa2c44dff5c
Author: Laimonas Simutis <>
Date:   2015-02-22T16:25:20Z

    use ToString


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message