lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hakeem Mohammed <hakeemo...@gmail.com>
Subject Re: New PR for expressions
Date Fri, 06 Feb 2015 02:20:58 GMT
OK, I synced my master. Now some tests are failing and the stacktrace
points to recent changes in Core. Thx

On Thu, Feb 5, 2015 at 3:16 AM, Itamar Syn-Hershko <itamar@code972.com>
wrote:

> If you can squash your own commits that'd be great, then you probably want
> to do "git rebase" before sending a PR because your master branch looks
> quite outdated
>
> --
>
> Itamar Syn-Hershko
> http://code972.com | @synhershko <https://twitter.com/synhershko>
> Freelance Developer & Consultant
> Lucene.NET committer and PMC member
>
> On Thu, Feb 5, 2015 at 6:15 AM, Hakeem Mohammed <hakeemosrc@gmail.com>
> wrote:
>
> > Hello Everyone,
> >
> > So I fixed all the remaining tests in Expressions. but when I try to
> create
> > a new PR, it again lists all the previous commits. Do I need to rebase
> --i
> > again?
> >
> > Thx
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message