lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guidotag <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Port from Support's to Util's PQ.
Date Fri, 20 Feb 2015 18:40:30 GMT
Github user guidotag commented on the pull request:

    https://github.com/apache/lucenenet/pull/103#issuecomment-75295146
  
    I definitely think we should only keep Util's PQ, because:
    - Having two PQ's will probably confuse somebody else in the future.
    - I prefer the raw array representation (and taking care of the resizes) rather than the
List one. Anyway, all the operations are implemented in a similar way, and there shouldn't
be big differences in their performances.
    - It is tested.
    - There is a way of going over the resize issue, as you point out.
    
    Deciding in a constructor if it should be resizable sounds good, and it is a reasonable
feature for a PQ. Also it shouldn't degrade the performance, since we only need to add a check
in the Add method.
    
    What do you think about adding a no-parameter constructor, and only allow resizes if constructed
that way?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message