lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guidotag <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Fix on the PQ.
Date Thu, 12 Feb 2015 20:15:44 GMT
Github user guidotag commented on the pull request:

    https://github.com/apache/lucenenet/pull/92#issuecomment-74144046
  
    @synhershko I finished reviewing Util's PQ and creating some more unit tests.
    I could change this PQ to require a comparer in the constructors, rather than needing
to inherit and overwrite the LessThan method, but, as you imagine, this would require changes
all over the code.
    
    This way of defining comparers via inheriting is flexible enough to allow two different
comparers for the same data type, though you'll need to create two different PQ type's which
is much less natural than just creating two different comparer functions and using them with
the same generic PQ.
    
    Passing a comparer seems a much better (and natural) approach to me, but since this would
require a lot of changes I'd like to discuss it before doing any move.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message