lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Fix on the PQ.
Date Wed, 11 Feb 2015 20:56:24 GMT
Github user synhershko commented on the pull request:

    https://github.com/apache/lucenenet/pull/92#issuecomment-73963006
  
    The Util one is taken directly from Java Lucene:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/util/PriorityQueue.java
    
    This is also why it has unit tests.
    
    Can you please verify the port of this class, and the tests, and move to using that one?
    
    Worth noting the TTR usage is basically wrong - it should have used the one in Util: 
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/search/TopTermsRewrite.java#L23
    
    So let's verify the port of that PQ and move to using it, deprecating the one in Support.
Once we stabilized everything I'll dig to see why it was introduced in the first place, and
remove it after all required lessons were learned.
    
    Good catch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message