lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Don't modify the collection while iteratin...
Date Wed, 04 Feb 2015 21:58:39 GMT
Github user synhershko commented on the pull request:

    https://github.com/apache/lucenenet/pull/74#issuecomment-72948582
  
    No idea why it was implemented that way. Not sure why it needed locking as well - the
method isn't synchronized in the original java code.
    
    Maybe it was an attempt at freezing state - but again I see no reason for that
    
    I just pushed another attempt at a fix, which is more in line with the original Java code
- please review
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java#L563


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message