lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Minor fixes in store
Date Wed, 04 Feb 2015 01:27:14 GMT
Github user laimis commented on the pull request:

    https://github.com/apache/lucenenet/pull/70#issuecomment-72773139
  
    @synhershko @guidotag I just setup Lucene 4.8 on my local with source code and IDE so
that I can debug (some of those multithreading bugs are brutal to catch otherwise), and can
confirm that in Java version, FSDirectory does not create the directory, it only says that
it does in the comment. If you look at the code, it make sense:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/store/FSDirectory.java#L128
    
    There is no explicit create being called, and constructing a File class with a path does
not create a file that represents such a path. When the port was being done, whoever read
that comment for "getCanonicalPath" that said "creating it if it doesn't exist." simply got
mislead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message