lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guidotag <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Minor fixes in store
Date Tue, 03 Feb 2015 18:15:10 GMT
Github user guidotag commented on the pull request:

    https://github.com/apache/lucenenet/pull/70#issuecomment-72703560
  
    @uschindler I didn't know what Lucene 5.0 does. I just tried to reproduce Lucene 4.8 behavior.
    Essentially the only difference between TestDontCreate in Java and C# was that the first
one didn't create the directory in the FS. That didn't make a difference in the final result.
When I did the change in GetCanonicalPath, Lucene.Net's test started to fail because there
was no directory to delete (Lucene does not fail because it checks if the directory exists
before attempting the deletion).
    
    Note that the tests TestNRTCachingDirectory/TestNoDir and TestFileSwitchDirectory/TestNoDir
now pass thanks to this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message