lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From synhershko <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Lucene.net.codecs.memory
Date Sun, 01 Feb 2015 22:36:32 GMT
Github user synhershko commented on the pull request:

    https://github.com/apache/lucenenet/pull/69#issuecomment-72388745
  
    Looks good! one lesson we learned post-sbyte removal is some calculations are relying
on the value to be -128 - 128 in range, so sbyte conversion is required before making the
actual calc. Just a thing to bear in mind, though once tests are ported and compiling those
should float up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message