lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Values iterator should not be used in bina...
Date Sun, 25 Jan 2015 22:07:04 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/60

    Values iterator should not be used in binary field portion

    AddSortedSetField was using values enumerator to return values for "AddBinaryField" downstream
code when it should only be used for WriteFST. This resulted in incorrect doc values being
recorded in the index. The Lucene code can be seen here:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/test-framework/src/java/org/apache/lucene/codecs/lucene42/Lucene42DocValuesConsumer.java#L308
    
    Note how it never uses values iterator when adding binary field portion.
    
    This fixes failures in TestLucene42DocValuesFormat tests, example:
    http://teamcity.codebetter.com/viewLog.html?buildId=179703&tab=buildResultsDiv&buildTypeId=LuceneNet_Core#testNameId5215188354472572854

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet Lucene42DocValuesConsumer_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/60.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #60
    
----
commit 3ce9d4c6cca26e065a91dd57963619f0da41abd8
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-25T22:00:40Z

    values iterator should not be used here

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message