lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: fix enumerator port to use appropriate log...
Date Wed, 21 Jan 2015 11:16:11 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/54

    fix enumerator port to use appropriate logic

    This makes several tests in Lucene45/Lucene40 namespace pass. The issue was with how the
logic in "insertEmptyValue" iterator was rewritten in .NET. Here is Lucene source:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/test-framework/src/java/org/apache/lucene/codecs/MissingOrdRemapper.java#L40
    
    The goal of this iterator was to first add empty byte array to the enumeration followed
by the actual elements returned by  "@in.MoveNext()". The port instead returned empty byte
array and then stopped: if seenEmpty OR @in.MoveNext() needs to be, if not seen empty, move
next and return empty, otherwise defer to wrapped iterator.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet MissingOrdRemapper_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #54
    
----
commit cf5ebe106b4f2df91ccc3dcf168e9b36eeaaab6a
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-21T11:11:41Z

    fix enumerator port to use appropriate logic

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message