lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Field cache sanity checker fixes
Date Sat, 10 Jan 2015 11:57:43 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/45

    Field cache sanity checker fixes

    Fixes for cache sanity checker and to Lucene.Net.Core/Index/CompositeReaderContext as
to how it stores some data.
    
    Cache sanity checker was throwing "value too large" exception when reading back the max
double stored in the document. The issue is that Convert.ToString on double uses 15 precision
digits when serializing so the value is rounded up making it to large when the value is extracted
from the doc.  Using double's ToString and specifing "R" format makes it use 17 precision
digits if needed.
    
    Lucene.Net.Core/Index/CompositeReaderContext was creating a new array from "IList<IndexReaderContext>
children" that was passed to it when the calling code was expecting it to store a reference
to the passed in array. Lucene version also makes sure that unmodifiableList is stored (https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/index/CompositeReaderContext.java)
so added UnmodifiableList implementation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet FieldCacheSanityChecker_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/45.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #45
    
----
commit 75841f715c788edfdc5c1bf0e47b939ec00f4948
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-06T11:34:14Z

    Merge branch 'master' of https://github.com/apache/lucenenet

commit 2570b13da72031870ba9ab31648b12110707bc5d
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-07T01:14:20Z

    Merge branch 'master' of https://github.com/apache/lucenenet

commit f6ba519b20996b60cffbe0d2832d0c60cf5c4dd0
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-07T01:37:20Z

    Merge branch 'master' of https://github.com/apache/lucenenet

commit be8194839cf94156231c9325c08a4281be7b4621
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-07T11:10:25Z

    Merge branch 'master' of https://github.com/apache/lucenenet

commit 29d6fd60de37921c949e200ebe49ccb5c0ea5e61
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-07T19:47:00Z

    Merge branch 'master' of https://github.com/apache/lucenenet

commit 115721ca26167ae3a81f3fc49e75f527a9f2c7a4
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-08T21:47:11Z

    Merge branch 'master' of https://github.com/apache/lucenenet

commit 4658205f90e6a19731252c616ba37622925f31f7
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-10T11:44:26Z

    make sure to use max precision on ToString for double

commit f33375d5d8f0e03486450f58110386f690019f39
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-10T11:47:04Z

    use UnmodifiedList as reference to children array

commit 7f3ba62273fe04061b1f262184dc14f6734320f8
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-10T11:47:41Z

    second param is number of items not max range

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message