lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: IOUtils fsync for directory fix
Date Mon, 05 Jan 2015 22:36:59 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/43

    IOUtils fsync for directory fix

    UnauthorizedAccessException is being thrown when FSDirectory uses fsync for files and
then tries to fsync a directory. The current implementation does not work for directories,
and it is not entirely clear what to do in those cases in a way that works across all platforms.
    
    It seems like Lucene version is failing for directories as well and they are handing it
by capturing IOException (which won't work with UnauthorizedAccessException):
    https://issues.apache.org/jira/browse/LUCENE-5588
    
    The discussion is still on going on the mailing list, checking this in and will adjust
based on feedback received.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet IOUtils_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #43
    
----
commit 7b8256c61f195c73a9ef071a3ac30a40f148daac
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-05T02:59:02Z

    fsync for directories on windows does not make sense

commit 1c1fc88ce879610f4efa5788c74281bf739563f9
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-05T22:21:58Z

    ignore fsync for directory completely

commit c299699801ff2abfb932997075c6addf1a5cb05a
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-05T22:23:58Z

    Merge https://github.com/apache/lucenenet into IOUtils_fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message