lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Fix test lucene40 doc values format
Date Fri, 02 Jan 2015 03:12:11 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/40

    Fix test lucene40 doc values format

    20 tests were failing in TestLucene40DocValuesFormat with "Lucene 4.0 does not support
SortedSet docvalues". Lucene40 codec does not support sorted set but the tests ran anyway.
What is happening is that the base class, BaseDocValuesFormatTestCase, uses the following
test to see if it should run the test:
    
    AssumeTrue("Codec does not support SORTED_SET", DefaultCodecSupportsSortedSet());
    
    It looks like AssumeTrue internally had commented out RandomizedTests call that was supposed
to mark the test as "inconclusive" with NUnit's Assume.That.
    
    Uncommented the call, now the tests are not marked as failures.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet fix_TestLucene40DocValuesFormat

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #40
    
----
commit d7bf8bd1a5905384e22307522d5dc241b51ce3d3
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-02T03:00:38Z

    enable assumetrue/false

commit 1b3a5212a9af76c0ca433190465d089e534d27fe
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2015-01-02T03:02:04Z

    undo accidental change that was checked in

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message