lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Expressions with some failing tests
Date Sat, 31 Jan 2015 01:15:08 GMT
Github user laimis commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/64#discussion_r23884265
  
    --- Diff: src/Lucene.Net.TestFramework/Util/LuceneTestCase.cs ---
    @@ -974,9 +974,7 @@ public static AlcoholicMergePolicy NewAlcoholicMergePolicy(Random
r, TimeZone tz
     
             public static LogMergePolicy NewLogMergePolicy(Random r)
             {
    -            // LUCENENET TODO: don't use LogByteSizeMergePolicy until it is fixed
    -            //LogMergePolicy logmp = r.NextBoolean() ? (LogMergePolicy)new LogDocMergePolicy()
: new LogByteSizeMergePolicy();
    -            LogMergePolicy logmp = new LogDocMergePolicy();
    +            LogMergePolicy logmp = r.NextBoolean() ? (LogMergePolicy)new LogDocMergePolicy()
: new LogByteSizeMergePolicy();
    --- End diff --
    
    Please put back the code that was there before as LogByteSizeMergePolicy is not behaving
properly at the moment. in certain scenarios.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message