lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Expressions with some failing tests
Date Thu, 29 Jan 2015 01:29:15 GMT
Github user laimis commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/64#discussion_r23740595
  
    --- Diff: src/Lucene.Net.Expressions/ExpressionComparator.cs ---
    @@ -0,0 +1,94 @@
    +using System;
    +using System.Collections.Generic;
    +using System.Diagnostics;
    +using System.IO;
    +using Lucene.Net.Index;
    +using Lucene.Net.Queries.Function;
    +using Lucene.Net.Search;
    +using Lucene.Net.Support;
    +
    +namespace Lucene.Net.Expressions
    +{
    +	/// <summary>A custom comparator for sorting documents by an expression</summary>
    +	internal class ExpressionComparator : FieldComparator<double>
    --- End diff --
    
    Lucene version is using Double instead of double, which can be null. Do we want to keep
it that way here too by using double? to match what Lucene has? It is hard to tell for me
if it ever deals with nulls, but something to consider.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message