lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Use reference instead of value type to mat...
Date Thu, 15 Jan 2015 11:11:54 GMT
Github user laimis commented on a diff in the pull request:

    https://github.com/apache/lucenenet/pull/47#discussion_r23003189
  
    --- Diff: src/Lucene.Net.Core/Codecs/Lucene45/Lucene45DocValuesConsumer.cs ---
    @@ -123,11 +123,13 @@ internal virtual void AddNumericField(FieldInfo field, IEnumerable<long>
values,
                 bool missing = false;
                 // TODO: more efficient?
                 HashSet<long> uniqueValues = null;
    +            // LUCENE TODO: is this necessary because of multiple iterations?
    --- End diff --
    
    That's good to know! Thanks!
    
    And actually that comment needs to go, I used another list to track objects in one iterator
so that I can pass them to the next but then changed the approach.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message