lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Dictionary fixes, corrected TestIndexWrite...
Date Wed, 31 Dec 2014 02:00:25 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/35

    Dictionary fixes, corrected TestIndexWriterUnicode test

    73 failures in the last TC test run with dictionary lookups in Lucene42DocValuesProducer
and LiveFieldValues, PR contains fixes for those.
    
    TestIndexWriterUnicode.TestAllUnicodeChars was failing, looks like a mistake in porting,
corrected based on Java branch (https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterUnicode.java#L221)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet dictionary_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
    
----
commit 0a03242e5f104c55e11a632ea8307e47d05bd0d4
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2014-12-31T01:53:55Z

    use GetTryValue for dictionary lookups

commit 80e1f9226bcd026abd747de702f85721173cc36d
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2014-12-31T01:55:10Z

    make sure to use offset / length when comparing uft8 buffer

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message