lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laimis <...@git.apache.org>
Subject [GitHub] lucenenet pull request: Classification tests
Date Wed, 24 Dec 2014 02:39:05 GMT
GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/27

    Classification tests

    High level summary of changes:
    
    - ported another class in Classification which I had forgotten: Utils/DatasetSplitter
    - ported all the tests in Classification, 9 total: 7 pass, 1 fails, 1 ignore
    - failing test appears to fail for random reasons, something that I see in the other tests
in core, will need to be addressed separately. The issue of the resources not getting cleaned
up properly somewhere in core because if I run tests one by one they pass.
    - 1 ignored test in SimpleNaiveBayesClassifierTest called TestNGramUsage. Depends on EdgeNGramTokenFilter
and other classes that are present in Lucene.Net.Analysis.Common but do not appear to be fully
ported or ready to be integrated.
    - fixed a bug in the previously ported KNearestNeighborClassifier that the tests uncovered

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet classification_tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit 78d60e37c09503c35d04b23d205b50a714cf9dd1
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2014-12-23T21:10:25Z

    classification tests and fixes

commit 3134b63c48366fd6f56b87dc984f0f97a33eb7fb
Author: Laimonas Simutis <laimis@gmail.com>
Date:   2014-12-24T02:16:07Z

    add Util\DataSplitter and corresponding tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message