lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Wyatt Barnett <wyatt.barn...@gmail.com>
Subject Re: Where should the tests be ported?
Date Tue, 23 Dec 2014 19:29:20 GMT
One note from the CI "team' here -- would Lucene.Net.Classification.Tests
work? The main reason is then it is easier to setup some convention based
test runners in builds because I can point things at *.Tests.dll.

No biggie if that don't work though.

On Tue, Dec 23, 2014 at 12:32 PM, Laimonas Simutis <laimis@gmail.com> wrote:

> Itamar,
>
> Sounds good, will place them at /src/Lucene.Net.Tests.Classification
> location.
>
>
> Thanks!
>
> Laimonas
>
> On Tue Dec 23 2014 at 12:28:45 PM Itamar Syn-Hershko <itamar@code972.com>
> wrote:
>
> > It should be at /src/Lucene.Net.Tests.Classification - we'll revisit this
> > pattern later to see it holds
> >
> > We'll probably need to refactor the Facets project's tests, I haven't
> > noticed that actually
> >
> > --
> >
> > Itamar Syn-Hershko
> > http://code972.com | @synhershko <https://twitter.com/synhershko>
> > Freelance Developer & Consultant
> > Author of RavenDB in Action <http://manning.com/synhershko/>
> >
> > On Tue, Dec 23, 2014 at 7:21 PM, Laimonas Simutis <laimis@gmail.com>
> > wrote:
> >
> > > Recently I ported the classification project and will be doing its test
> > > project next.
> > >
> > > My question is, which directory should the tests go to in Lucene.net? I
> > am
> > > looking at the "core" for a pattern, and see these two relevant
> > > directories:
> > >
> > > /src/Lucene.Net.Core
> > > /src/Lucene.Net.Tests/core
> > >
> > > Should the classification tests go to /src/Lucene.Net.Tests/
> > classification
> > > ?
> > >
> > > Looking for some guidance.
> > >
> > > Somewhat related, I see that Facet project has its test project in
> > > /src/Lucene.Net.Tests/core even though java version (
> > >
> > > https://github.com/apache/lucene-solr/tree/lucene_solr_
> > 4_8_0/lucene/core/src/test/org/apache/lucene
> > > )
> > > has no facet directory or tests present. Perhaps it should be located
> > here:
> > >
> > > /src/Lucene.Net.Tests/facet
> > >
> > > What do you guys think? I will start the port of classification tests,
> > but
> > > will wait on your guidance before sending in PR.
> > >
> > >
> > > Laimonas
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message