lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Laimonas Simutis <lai...@gmail.com>
Subject Re: [GitHub] lucenenet pull request: throw a more informative exception to trac...
Date Tue, 30 Dec 2014 16:03:35 GMT
Cool, now it is clear what the issue is:

A combination of what TC build directory path contains and how the path
parsing code is written. Look up block at
https://github.com/apache/lucenenet/blob/master/src/Lucene.Net.TestFramework/Util/Paths.cs#L146
 should be rewritten to do straight up IndexOf on "buildPathPart" and then
on "binPathPart" if the first one returns -1.

Should have a PR for it later in the evening after work if no one gets to
it first. From the logs it looks like some 60+ tests are failing due to
this issue. I don't expect all of them to resolve after the fix but again,
gets us moving forward.



On Tue Dec 30 2014 at 1:15:17 AM synhershko <git@git.apache.org> wrote:

> Github user synhershko commented on the pull request:
>
>     https://github.com/apache/lucenenet/pull/32#issuecomment-68333143
>
>     Merged now, thanks!
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message