lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Irwin <pir...@feature23.com>
Subject Re: Process for accepting PRs from GitHub
Date Wed, 26 Nov 2014 17:25:29 GMT
Awesome, thanks Prescott!


Paul Irwin
Lead Software Engineer
feature[23]

Email: pirwin@feature23.com
Cell: 863-698-9294

On Wed, Nov 26, 2014 at 12:20 PM, Prescott Nasser <geobmx540@hotmail.com>
wrote:

> I used this as my guide:
> https://mahout.apache.org/developers/github.html (we should put this in
> our docs too :) )
>
> > Date: Wed, 26 Nov 2014 09:42:04 -0500
> > Subject: Process for accepting PRs from GitHub
> > From: pirwin@feature23.com
> > To: dev@lucenenet.apache.org
> >
> > I love PRs on GitHub because they are expressive, can contain
> discussions,
> > easy to see the status, etc. But what is the process for accepting a PR
> > from GitHub since the apache/lucene.net GitHub repo is a read-only
> clone of
> > the Apache git repo (or has that changed)?
> >
> > I can help with reviewing and accepting PRs as I'm a committer, but I
> don't
> > want to do things the wrong way. Itamar, are you checking out the PR
> branch
> > locally, merging into master, then pushing up to the apache git repo?
> >
> > Thanks,
> >
> > Paul Irwin
> > Lead Software Engineer
> > feature[23]
> >
> > Email: pirwin@feature23.com
> > Cell: 863-698-9294
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message