lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Itamar Syn-Hershko <ita...@code972.com>
Subject Paul: why are we using sbyte?
Date Mon, 07 Apr 2014 20:41:39 GMT
Hi Paul,

Please refer to this commit:
https://github.com/apache/lucene.net/commit/8c23317c905d79823fd168ede778820439c8b163

Why have you moved to using sbyte?

I know this is one of the differences between Java and .NET, but we are on
.NET and should allow using byte.

Having Field implementation to expect sbyte[] is almost useless as
Encoding.GetEncoding(encoding).GetBytes(str); for example returns byte[].

Can we change it back please so it uses byte everywhere, especially on the
public facing API?

--

Itamar Syn-Hershko
http://code972.com | @synhershko <https://twitter.com/synhershko>
Freelance Developer & Consultant
Author of RavenDB in Action <http://manning.com/synhershko/>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message