lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Itamar Syn-Hershko <ita...@code972.com>
Subject Re: Contrib/Spatial port
Date Mon, 21 Apr 2014 17:18:38 GMT
I'll have a look during the next week, thanks for your effort

--

Itamar Syn-Hershko
http://code972.com | @synhershko <https://twitter.com/synhershko>
Freelance Developer & Consultant
Author of RavenDB in Action <http://manning.com/synhershko/>


On Mon, Apr 21, 2014 at 2:03 PM, Ramkumar Krishnamoorthy <
ramkumar1985@gmail.com> wrote:

> Hi Guys,
>
> I think I have completed porting Contrib/Spatial and Spatial.NTS.
> Did run into couple of questions, but took some educated decisions.
>
> First is the usage of sbyte. I know there were some recent discussion about
> the usage of sbyte. And I did run into code, which needed sbyte as a param.
> Since there is sbyte used already in the source and just to get it compiled
> for now, I have used sbyte. I guess there will be some task in future, if
> needed, to convert all sybte usage back to byte.
>
> The TermsEnumCompatibility and CompatibilityExtensions classes. I couldn't
> find the matching code in Java. And the code was not used anywhere else, so
> not sure if we still needed these classes. Again just to get the code
> compiled, I have removed TermsEnumCompatibility class and deleted the error
> methods in CompatibilityExtensions.
>
> Hope I made the right decisions.
>
> Guess next step would be someone to review my changes. They can be found
> at.
> https://github.com/cyberram/lucene.net/tree/branch_4x
>
> Cheers,
> Kumar
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message