lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michael herndon <mhern...@michaelherndon.com>
Subject Re: Lucene.net 4?
Date Thu, 06 Mar 2014 16:41:35 GMT
These items are good ideas and should be entered into Jira as some kind of
project meta task so that decisions can be tracked and prioritized.

With a code base of this size, each project wide change like switching
asserts comes at a cost and so does getting automation right.

Is the primary goal of branch_4x to ship soon as possible? or is it to
increase the sustainability of the project ?

These goals are not mutually exclusive. However, it is easier to prioritize
work items if there is some primary goal or agreed upon prioritization of
goals.

-----------

I'll start with getting the core test library and test framework to compile
and making it obvious which classes need to be converted / updated.





On Thu, Mar 6, 2014 at 11:20 AM, Paul Irwin <pirwin@feature23.com> wrote:

> I'll let someone else drive that... haha
>
> I am not a R# user. But I did put all the logic for doing the syntax
> conversion in a separate library in that repo, so it should be relatively
> easy to take that and add to a plugin, I would guess.
>
>
> On Thu, Mar 6, 2014 at 11:17 AM, Itamar Syn-Hershko <itamar@code972.com
> >wrote:
>
> > Cool, then I'll look into that. Any chance you can make it a R# plugin?
> >
> > --
> >
> > Itamar Syn-Hershko
> > http://code972.com | @synhershko <https://twitter.com/synhershko>
> > Freelance Developer & Consultant
> > Author of RavenDB in Action <http://manning.com/synhershko/>
> >
> >
> > On Thu, Mar 6, 2014 at 4:11 PM, Paul Irwin <pirwin@feature23.com> wrote:
> >
> > > That is exactly what the tool I created does, it does a syntactic
> > > conversion only of Java to C# and does that work for you. It does not
> > > resolve symbols or anything. It should help you go a bit faster than
> > doing
> > > the syntactic conversion manually by copy-paste.
> > >
> > >
> > > On Thu, Mar 6, 2014 at 10:43 AM, Itamar Syn-Hershko <
> itamar@code972.com
> > > >wrote:
> > >
> > > > For porting core parts of the code? sure. I just think its a waste of
> > > time
> > > > to work on porting tests, so the only thing I want to be doing is
> > > > copy-paste and then as few changes as possible (replacing import with
> > > > using, package with namespace, etc - which if we could automate that
> > > could
> > > > be great) and the rest should just compile and work because the tests
> > > > framework already supports most of what happens there.
> > > >
> > > > --
> > > >
> > > > Itamar Syn-Hershko
> > > > http://code972.com | @synhershko <https://twitter.com/synhershko>
> > > > Freelance Developer & Consultant
> > > > Author of RavenDB in Action <http://manning.com/synhershko/>
> > > >
> > > >
> > > > On Thu, Mar 6, 2014 at 3:37 PM, Paul Irwin <pirwin@feature23.com>
> > wrote:
> > > >
> > > > > I like that thinking for unit tests. I wrote a quick Java to C#
> > > converter
> > > > > since Sharpen wasn't maintained that adds 1.7 support. It uses
> Roslyn
> > > for
> > > > > the C# generation. I used this for some of my later porting work.
> > It's
> > > > far
> > > > > from perfect, but handles most of the Java syntax correctly. It
> warns
> > > you
> > > > > if it encounters an unsigned right-shift or
> > > > > break-to-label/continue-to-label.
> > > > >
> > > > > Repo: https://github.com/paulirwin/JavaToCSharp
> > > > >
> > > > > Maybe that will help?
> > > > >
> > > > >
> > > > > On Thu, Mar 6, 2014 at 10:23 AM, Itamar Syn-Hershko <
> > > itamar@code972.com
> > > > > >wrote:
> > > > >
> > > > > > +1
> > > > > >
> > > > > > What I'll be interested in having is a unit-testing framework
for
> > > > > > Lucene.NET where Java test classes can be mostly copy-pasted
and
> > just
> > > > > run.
> > > > > > That'd probably involve many extension method and a smart base
> > class
> > > > that
> > > > > > will map Java syntax stuff like Array.copy or asserts into their
> C#
> > > > > > equivalents.
> > > > > >
> > > > > > While it makes sense to have the core comply with .NET
> standards, I
> > > see
> > > > > no
> > > > > > point in duplicating the effort for testing.
> > > > > >
> > > > > > I was thinking of doing that myself but haven't got around to
> doing
> > > it
> > > > > yet.
> > > > > > Will be happy to help tho.
> > > > > >
> > > > > > --
> > > > > >
> > > > > > Itamar Syn-Hershko
> > > > > > http://code972.com | @synhershko <https://twitter.com/synhershko
> >
> > > > > > Freelance Developer & Consultant
> > > > > > Author of RavenDB in Action <http://manning.com/synhershko/>
> > > > > >
> > > > > >
> > > > > > On Thu, Mar 6, 2014 at 3:13 PM, michael herndon <
> > > > > > mherndon@michaelherndon.com
> > > > > > > wrote:
> > > > > >
> > > > > > > I don't mind working on the tests or working towards getting
> the
> > > > tests
> > > > > > to a
> > > > > > > state where they compile and pass, but I don't want to
> duplicate
> > > work
> > > > > > > either.
> > > > > > >
> > > > > > > If the the tests are not currently being worked on, then
I'll
> go
> > > > ahead
> > > > > > and
> > > > > > > start working on getting the the Core test library into
a state
> > > that
> > > > it
> > > > > > can
> > > > > > > be compiled and run tests.
> > > > > > >
> > > > > > >
> > > > > > > On Thu, Mar 6, 2014 at 9:56 AM, Paul Irwin <
> pirwin@feature23.com
> > >
> > > > > wrote:
> > > > > > >
> > > > > > > > I am not, I hope to jump back in soon, maybe even
today.
> > > > > > > >
> > > > > > > >
> > > > > > > > On Thu, Mar 6, 2014 at 9:34 AM, michael herndon <
> > > > > > > > mherndon@michaelherndon.com
> > > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Is any one working on the tests in branch_4x
for core at
> the
> > > > > moment?
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Mon, Mar 3, 2014 at 5:35 PM, Itamar Syn-Hershko
<
> > > > > > itamar@code972.com
> > > > > > > > > >wrote:
> > > > > > > > >
> > > > > > > > > > Let's keep the discussion in the mailing
list. Keep
> pushing
> > > > > commits
> > > > > > > to
> > > > > > > > > your
> > > > > > > > > > branch, and when you fill it is ready to
be merged let us
> > > know.
> > > > > > > > > >
> > > > > > > > > > --
> > > > > > > > > >
> > > > > > > > > > Itamar Syn-Hershko
> > > > > > > > > > http://code972.com | @synhershko <
> > > > https://twitter.com/synhershko
> > > > > >
> > > > > > > > > > Freelance Developer & Consultant
> > > > > > > > > > Author of RavenDB in Action <
> > http://manning.com/synhershko/>
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On Tue, Mar 4, 2014 at 12:33 AM, Jude Bowman
<
> > > judebo@gmail.com
> > > > >
> > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > Ok, thanks for the feedback.  I added
a Jira task for
> > this
> > > > > work:
> > > > > > > > > > >
> > > > > > > > > > > https://issues.apache.org/jira/browse/LUCENENET-540
> > > > > > > > > > >
> > > > > > > > > > > I will keep emailing Paul my commit's
so that they can
> be
> > > > > merged
> > > > > > > into
> > > > > > > > > the
> > > > > > > > > > > branch.  Please let me know if I should
change the way
> I
> > am
> > > > > doing
> > > > > > > > > > anything
> > > > > > > > > > > or any other feedback that may be helpful.
> > > > > > > > > > >
> > > > > > > > > > > Thanks
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > On Mon, Mar 3, 2014 at 5:27 PM, Itamar
Syn-Hershko <
> > > > > > > > itamar@code972.com
> > > > > > > > > > >wrote:
> > > > > > > > > > >
> > > > > > > > > > >> Please try to commit more often...
> > > > > > > > > > >>
> > > > > > > > > > >> Thanks for putting an effort on
this
> > > > > > > > > > >>
> > > > > > > > > > >> --
> > > > > > > > > > >>
> > > > > > > > > > >> Itamar Syn-Hershko
> > > > > > > > > > >> http://code972.com | @synhershko
<
> > > > > > https://twitter.com/synhershko>
> > > > > > > > > > >> Freelance Developer & Consultant
> > > > > > > > > > >> Author of RavenDB in Action <
> > > http://manning.com/synhershko/
> > > > >
> > > > > > > > > > >>
> > > > > > > > > > >>
> > > > > > > > > > >> On Tue, Mar 4, 2014 at 12:26 AM,
Jude Bowman <
> > > > > judebo@gmail.com>
> > > > > > > > > wrote:
> > > > > > > > > > >>
> > > > > > > > > > >>> In order to keep moving along,
I decided to halt the
> > > work I
> > > > > was
> > > > > > > > doing
> > > > > > > > > > in
> > > > > > > > > > >>> Spatial and started adding
classes to
> > > > > > > > > > >>> "\src\contrib\Analyzers\Miscellaneous\"
folder to
> match
> > > > what
> > > > > is
> > > > > > > in
> > > > > > > > > the
> > > > > > > > > > >>> "lucene_solr_4_3" Java branch.
> > > > > > > > > > >>>
> > > > > > > > > > >>> Here is a commit with a lot
of new classes added as
> > well
> > > > as a
> > > > > > few
> > > > > > > > > other
> > > > > > > > > > >>> changes needed to work in Miscellaneous.
> > > > > > > > > > >>>
> > > > > > > > > > >>>
> > > > > > > > > > >>>
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/judebowman/lucene.net/commit/ad93e0ffc37e9338d31335ff7bd1429e1a89b09c
> > > > > > > > > > >>>
> > > > > > > > > > >>> Is it preferable to commit
more often with fine
> grain,
> > or
> > > > is
> > > > > > > what I
> > > > > > > > > did
> > > > > > > > > > >>> fine where I have a commit
with a lot of changes?
> > > > > > > > > > >>>
> > > > > > > > > > >>> Thanks
> > > > > > > > > > >>>
> > > > > > > > > > >>>
> > > > > > > > > > >>> On Sat, Feb 22, 2014 at 5:47
PM, Jude Bowman <
> > > > > judebo@gmail.com
> > > > > > >
> > > > > > > > > wrote:
> > > > > > > > > > >>>
> > > > > > > > > > >>>> Sure.  I stated by looking
at the Java version from
> > the
> > > > > > > > > > lucene_solr_4_3
> > > > > > > > > > >>>> branch. located at
> > > > > > > > > > >>>>
> > > > > > > > > > >>>>
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/lucene-solr/tree/lucene_solr_4_3/lucene/spatial/src/java/org/apache/lucene/spatial
> > > > > > > > > > >>>>
> > > > > > > > > > >>>> I basically was attempting
to
> > > > > > > > > > >>>> 1) get rid of all the build
errors in the classes
> that
> > > > > already
> > > > > > > > > exist,
> > > > > > > > > > >>>> 2) remove the classes/files
(such as the
> Spatial\BBox
> > > > > > > > subdirectory)
> > > > > > > > > > >>>> that do not exist in the
4.3 Java version,
> > > > > > > > > > >>>> 3) Add the new classes
that are in the Java 4.3
> > version
> > > > that
> > > > > > do
> > > > > > > > not
> > > > > > > > > > >>>> exist in the .NET version
yet.
> > > > > > > > > > >>>>
> > > > > > > > > > >>>> I was not aware of spatial4j/spatial4n
component of
> > this
> > > > > > > project.
> > > > > > > > >  Is
> > > > > > > > > > >>>> mirroring the code in the
above Java 4.3 branch not
> > the
> > > > > > correct
> > > > > > > > > thing
> > > > > > > > > > to be
> > > > > > > > > > >>>> doing for this Spatial
project?
> > > > > > > > > > >>>>
> > > > > > > > > > >>>> If I did pick too hard
of a task to start with, I do
> > not
> > > > > mind
> > > > > > > > moving
> > > > > > > > > > to
> > > > > > > > > > >>>> something a little more
simpler.  If you have any
> > > > > > > > recommendations, I
> > > > > > > > > > would
> > > > > > > > > > >>>> appreciate it.
> > > > > > > > > > >>>>
> > > > > > > > > > >>>> Thanks
> > > > > > > > > > >>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>> On Sat, Feb 22, 2014 at
5:29 PM, Itamar Syn-Hershko
> <
> > > > > > > > > > itamar@code972.com
> > > > > > > > > > >>>> > wrote:
> > > > > > > > > > >>>>
> > > > > > > > > > >>>>> Let's work using JIRA,
as there's always some form
> of
> > > > > > > discussion
> > > > > > > > > > >>>>> required.
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> Jude, can you please
describe what you did there?
> The
> > > > > spatial
> > > > > > > > > module
> > > > > > > > > > >>>>> needs to be brought
in line with the latest
> spatial4j
> > > > (see
> > > > > > > > > > spatial4n, which
> > > > > > > > > > >>>>> needs to be brought
up to date as well) and the
> > Spatial
> > > > > > module
> > > > > > > > > > there. There
> > > > > > > > > > >>>>> have been a lot of
API changes there. I think you
> > > picked
> > > > > > quite
> > > > > > > a
> > > > > > > > > > tough task
> > > > > > > > > > >>>>> as your first...
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> --
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> Itamar Syn-Hershko
> > > > > > > > > > >>>>> http://code972.com
| @synhershko <
> > > > > > > https://twitter.com/synhershko
> > > > > > > > >
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> Freelance Developer
& Consultant
> > > > > > > > > > >>>>> Author of RavenDB in
Action <
> > > > > http://manning.com/synhershko/>
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>> On Sun, Feb 23, 2014
at 12:22 AM, Paul Irwin <
> > > > > > > > pirwin@feature23.com
> > > > > > > > > > >wrote:
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>>> Jude,
> > > > > > > > > > >>>>>>
> > > > > > > > > > >>>>>> Thanks for getting
going on this! No we do not use
> > > pull
> > > > > > > requests
> > > > > > > > > on
> > > > > > > > > > >>>>>> GitHub currently.
Once you're ready for something
> to
> > > go
> > > > > > > > upstream,
> > > > > > > > > > let me
> > > > > > > > > > >>>>>> know and I can
pull from your fork and push it up.
> > > > > > Eventually
> > > > > > > we
> > > > > > > > > > can get
> > > > > > > > > > >>>>>> you commit access
if you make enough progress to
> > make
> > > it
> > > > > > > > > > worthwhile. We
> > > > > > > > > > >>>>>> haven't yet been
using Jira for any of the 4.x
> work
> > > as I
> > > > > > don't
> > > > > > > > > > think it's
> > > > > > > > > > >>>>>> quite to that stage
of needing tickets for issues.
> > > > > > > > > > >>>>>>
> > > > > > > > > > >>>>>>
> > > > > > > > > > >>>>>> On Sat, Feb 22,
2014 at 5:20 PM, Jude Bowman <
> > > > > > > judebo@gmail.com
> > > > > > > > > > >wrote:
> > > > > > > > > > >>>>>>
> > > > > > > > > > >>>>>>> I started by
working in the Contrib.Spatial
> project
> > > and
> > > > > > made
> > > > > > > a
> > > > > > > > > lot
> > > > > > > > > > >>>>>>> of progress
to get the number of build errors
> down.
> > > >  From
> > > > > > my
> > > > > > > > > > public repo
> > > > > > > > > > >>>>>>> where I cloned
the lucene.net repo, I committed
> > and
> > > > then
> > > > > > > sent
> > > > > > > > a
> > > > > > > > > > >>>>>>> Pull request
through GitHub.  If it does not show
> > on
> > > > your
> > > > > > > end,
> > > > > > > > or
> > > > > > > > > > I did not
> > > > > > > > > > >>>>>>> follow the
correct steps to get changes to you,
> > > please
> > > > > let
> > > > > > me
> > > > > > > > > know.
> > > > > > > > > > >>>>>>>
> > > > > > > > > > >>>>>>> Should I create
a ticket in Jira to complete the
> > > > porting
> > > > > of
> > > > > > > the
> > > > > > > > > > >>>>>>> Spatial project,
and continue to work on that
> until
> > > it
> > > > is
> > > > > > > > > complete?
> > > > > > > > > > >>>>>>>
> > > > > > > > > > >>>>>>> Thanks,
> > > > > > > > > > >>>>>>>
> > > > > > > > > > >>>>>>> Jude
> > > > > > > > > > >>>>>>>
> > > > > > > > > > >>>>>>>
> > > > > > > > > > >>>>>>> On Wed, Feb
12, 2014 at 12:04 PM, Prescott
> Nasser <
> > > > > > > > > > >>>>>>> geobmx540@hotmail.com>
wrote:
> > > > > > > > > > >>>>>>>
> > > > > > > > > > >>>>>>>> Jude -
> > > > > > > > > > >>>>>>>>
> > > > > > > > > > >>>>>>>> Thanks
for offering to help, right now we are
> > > looking
> > > > at
> > > > > > > > porting
> > > > > > > > > > >>>>>>>> 4.0 over
(take a look at this page)
> > > > > > > > > > >>>>>>>>
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/LUCENENET/Lucene+4x+Port+Progress
> > > > > > > > > > >>>>>>>>
> > > > > > > > > > >>>>>>>> I believe
the current process would be to check
> > out
> > > > our
> > > > > > > JIRA (
> > > > > > > > > > >>>>>>>> https://issues.apache.org/jira/browse/LUCENENET-
> > > > right
> > > > > > now
> > > > > > > > > it's
> > > > > > > > > > >>>>>>>> pretty
empty, so you might create a ticket for
> > your
> > > > > > specific
> > > > > > > > > > feature).
> > > > > > > > > > >>>>>>>> Using the
page above and possibly Paul and
> > Itamar's
> > > > > help,
> > > > > > > pick
> > > > > > > > > > out a
> > > > > > > > > > >>>>>>>> feature,
create your ticket for that feature,
> and
> > > then
> > > > > > > create
> > > > > > > > a
> > > > > > > > > > pull
> > > > > > > > > > >>>>>>>> request.
> > > > > > > > > > >>>>>>>>
> > > > > > > > > > >>>>>>>> We'll need
to have you fill out a CLA for any
> > > > > > contribuations
> > > > > > > > you
> > > > > > > > > > >>>>>>>> make, just
some paperwork. We can do that when a
> > > pull
> > > > > > > request
> > > > > > > > > > comes in.
> > > > > > > > > > >>>>>>>>
> > > > > > > > > > >>>>>>>> Paul or
Itamar (or anyone else), is there a
> > specific
> > > > > > feature
> > > > > > > > > that
> > > > > > > > > > >>>>>>>> Jude could
work on for us?
> > > > > > > > > > >>>>>>>>
> > > > > > > > > > >>>>>>>> ~P
> > > > > > > > > > >>>>>>>>
> > > > > > > > > > >>>>>>>> > To:
dev@lucenenet.apache.org
> > > > > > > > > > >>>>>>>> > From:
jude_bowman@hotmail.com
> > > > > > > > > > >>>>>>>> > Subject:
Re: Lucene.net 4?
> > > > > > > > > > >>>>>>>> > Date:
Thu, 6 Feb 2014 22:58:06 +0000
> > > > > > > > > > >>>>>>>> >
> > > > > > > > > > >>>>>>>> > I
would love to contribute. I am a Sr.
> Software
> > > > > Engineer
> > > > > > > who
> > > > > > > > > is
> > > > > > > > > > >>>>>>>> currently
> > > > > > > > > > >>>>>>>> > using
Lucene.net 3.0.3. I have never worked on
> > an
> > > > open
> > > > > > > > source
> > > > > > > > > > >>>>>>>> project
but I
> > > > > > > > > > >>>>>>>> > have
been wanting to, so I am hoping this
> would
> > > be a
> > > > > > good
> > > > > > > > > > >>>>>>>> oppertunity
to do
> > > > > > > > > > >>>>>>>> > so.
Please contact me at
> > jude_bowman@hotmail.comifI
> > > > > > > would
> > > > > > > > > be
> > > > > > > > > > >>>>>>>> eligible
to
> > > > > > > > > > >>>>>>>> > contribute.
> > > > > > > > > > >>>>>>>> >
> > > > > > > > > > >>>>>>>> > Thanks!
> > > > > > > > > > >>>>>>>> >
> > > > > > > > > > >>>>>>>> > Jude
> > > > > > > > > > >>>>>>>> >
> > > > > > > > > > >>>>>>>> >
> > > > > > > > > > >>>>>>>>
> > > > > > > > > > >>>>>>>
> > > > > > > > > > >>>>>>>
> > > > > > > > > > >>>>>>
> > > > > > > > > > >>>>>>
> > > > > > > > > > >>>>>> --
> > > > > > > > > > >>>>>>
> > > > > > > > > > >>>>>> Paul Irwin
> > > > > > > > > > >>>>>> Lead Software Engineer
> > > > > > > > > > >>>>>> feature[23]
> > > > > > > > > > >>>>>>
> > > > > > > > > > >>>>>> Email: pirwin@feature23.com
> > > > > > > > > > >>>>>> Cell: 863-698-9294
> > > > > > > > > > >>>>>>
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>>
> > > > > > > > > > >>>>
> > > > > > > > > > >>>
> > > > > > > > > > >>
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > >
> > > > > > > > Paul Irwin
> > > > > > > > Lead Software Engineer
> > > > > > > > feature[23]
> > > > > > > >
> > > > > > > > Email: pirwin@feature23.com
> > > > > > > > Cell: 863-698-9294
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > >
> > > > > Paul Irwin
> > > > > Lead Software Engineer
> > > > > feature[23]
> > > > >
> > > > > Email: pirwin@feature23.com
> > > > > Cell: 863-698-9294
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > Paul Irwin
> > > Lead Software Engineer
> > > feature[23]
> > >
> > > Email: pirwin@feature23.com
> > > Cell: 863-698-9294
> > >
> >
>
>
>
> --
>
> Paul Irwin
> Lead Software Engineer
> feature[23]
>
> Email: pirwin@feature23.com
> Cell: 863-698-9294
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message