lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Diss (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENENET-531) Incorrect parsing of when resetting a prefix tree node ending in LEAF_BYTE
Date Fri, 13 Dec 2013 01:10:07 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847009#comment-13847009
] 

John Diss commented on LUCENENET-531:
-------------------------------------

I haven't executed that patch (i should be sleeping :) but it looks almost identical to what
I came up with

On 13 Dec 2013 00:02, "Itamar Syn-Hershko (JIRA)" <jira@apache.org> wrote:

    [ https://issues.apache.org/jira/browse/LUCENENET-531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846942#comment-13846942
]

Itamar Syn-Hershko commented on LUCENENET-531:
----------------------------------------------

I'm pretty sure this patch fixes it - can you check?

https://github.com/ayende/lucene.net/commit/007fb4b7b4c479ec9dd81afac8fd3c43cf0b5319




--
This message was sent by Atlassian JIRA
(v6.1.4#6159)



> Incorrect parsing of when resetting a prefix tree node ending in LEAF_BYTE
> --------------------------------------------------------------------------
>
>                 Key: LUCENENET-531
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-531
>             Project: Lucene.Net
>          Issue Type: Bug
>          Components: Lucene.Net Contrib
>    Affects Versions: Lucene.Net 3.0.3
>         Environment: Lucene.Net.Contrib.Spatial
>            Reporter: John Diss
>            Priority: Critical
>         Attachments: lucene.net.contrib.spatial.node.patch
>
>
> When a prefix tree node is constructed, there is an explicit check to test if the last
char is LEAF_BYTE and its presence is handled appropriately. If the node is reused via the
node.Reset method there is no such check which leads to issues if presented with a token ending
in LEAF_BYTE. This manifests as "Unexpected char: +" in method QuadPrefixTree.QuadCell.MakeShape.
> I think this happens when building a cell from e.g a rectangle shape query parameter
where the cell level is < grid depth. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message