lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Prescott Nasser <geobmx...@hotmail.com>
Subject RE: svn commit: r1391857 - in /lucene.net/trunk/build/scripts: All/Lucene.Net.nuspec Contrib/Lucene.Net.Contrib.nuspec Core/Lucene.Net.Core.nuspec Spatial.NTS/Lucene.Net.Spatial.NTS.nuspec Spatial/Lucene.Net.Spatial.nuspec
Date Sun, 30 Sep 2012 03:09:45 GMT
Should we include them in the release, or only as part of the nuget package?

----------------------------------------
> Date: Sat, 29 Sep 2012 19:09:52 -0700
> Subject: Re: svn commit: r1391857 - in /lucene.net/trunk/build/scripts: All/Lucene.Net.nuspec
Contrib/Lucene.Net.Contrib.nuspec Core/Lucene.Net.Core.nuspec Spatial.NTS/Lucene.Net.Spatial.NTS.nuspec
Spatial/Lucene.Net.Spatial.nuspec
> From: currens.chris@gmail.com
> To: dev@lucenenet.apache.org
>
> Regarding PDBs:
>
> a) You can get a decent debugging experience without them, thanks to
> .NET metadata, but the experience is *considerably* better when they
> are present, since you can actually get source code line numbers,
> instead of just a faulting function name.
>
> b) If we have to enable PDBs for release mode, it's important that we
> select the "pdb-only" option and not "full". Full impacts the size
> and quality of the jitted code.
>
> I think that we should definitely include them.
>
> On Sat, Sep 29, 2012 at 12:13 PM, Itamar Syn-Hershko <itamar@code972.com> wrote:
> > inline
> >
> > On Sat, Sep 29, 2012 at 9:02 PM, Prescott Nasser <geobmx540@hotmail.com>wrote:
> >
> >> Having some difficulty following, do I understand this right:
> >>
> >> 1. Spatial contrib is it's own nuget package. (Dependant on Spatial4n -
> >> which is not part of our repository)
> >>
> >
> > Yes, because it needs spatial4n which we can't ship with, and we don't want
> > to have it as a dependency for all other contribs as well
> >
> >
> >> 2. Spatial.NTS depends on Spatial4n.NTS (not part of our repository),
> >> which then depends on NTS? (If that's the case, then I'd say keep the
> >> dependancy on Spatial4n.NTS and that will make sure NTS is pulled in as
> >> well.
> >>
> >
> > Yes
> >
> >
> >> 3. Which binaries are missing? Are these missing in the RC1 candidate? I
> >> should probably cut a new release
> >>
> >
> > The 3.5 ones in the nuget packages, for everything
> >
> >
> >>
> >> I'll show my lack of understanding - why should we be including the PDB's?
> >> And are you saying the pdb's for all dlls? or just spatial?
> >>
> >
> > For debugging purposes, you'll get nicer stack traces if anything goes
> > wrong. For everything, not just spatial. We'll need to set the solutions to
> > output PDBs for the release versions if they aren't set to do so yet.
> >
> >
> >>
> >> ----------------------------------------
> >> > Date: Sat, 29 Sep 2012 20:49:04 +0200
> >> > Subject: Re: svn commit: r1391857 - in /lucene.net/trunk/build/scripts:
> >> All/Lucene.Net.nuspec Contrib/Lucene.Net.Contrib.nuspec
> >> Core/Lucene.Net.Core.nuspec Spatial.NTS/Lucene.Net.Spatial.NTS.nuspec
> >> Spatial/Lucene.Net.Spatial.nuspec
> >> > From: itamar@code972.com
> >> > To: dev@lucenenet.apache.org
> >> >
> >> > Updated the URL for the current website, and split the Spatial contrib
to
> >> > its own package which is dependent on the spatial4n package on nuget
> >> > (instead of having the entire contrib stuff depend on it).
> >> >
> >> > Not sure if I should keep the dependency on NTS itself for the
> >> Spatial.NTS
> >> > package or not - it will be downloaded anyway (spatial4n.NTS depends on
> >> > it), the question is whether or not it should be added to the consumer
> >> > project)
> >> >
> >> > I also noticed the 3.5 binaries aren't added to the package, and we
> >> > probably want to change that. I'd also advise on bundling the PDBs along.
> >> >
> >> > On Sat, Sep 29, 2012 at 8:38 PM, <synhershko@apache.org> wrote:
> >> >
> >> > > Author: synhershko
> >> > > Date: Sat Sep 29 18:38:27 2012
> >> > > New Revision: 1391857
> >> > >
> >> > > URL: http://svn.apache.org/viewvc?rev=1391857&view=rev
> >> > > Log:
> >> > > Updating nuspecs, also creating dedicated nuget package for spatial
> >> contrib
> >> > >
> >> > > Added:
> >> > > lucene.net/trunk/build/scripts/Spatial/Lucene.Net.Spatial.nuspec
> >> > > - copied, changed from r1391728,
> >> > > lucene.net/trunk/build/scripts/Core/Lucene.Net.Core.nuspec
> >> > > Modified:
> >> > > lucene.net/trunk/build/scripts/All/Lucene.Net.nuspec
> >> > > lucene.net/trunk/build/scripts/Contrib/Lucene.Net.Contrib.nuspec
> >> > > lucene.net/trunk/build/scripts/Core/Lucene.Net.Core.nuspec
> >> > >
> >> > >
> >> lucene.net/trunk/build/scripts/Spatial.NTS/Lucene.Net.Spatial.NTS.nuspec
> >> > >
> >> > > Modified: lucene.net/trunk/build/scripts/All/Lucene.Net.nuspec
> >> > > URL:
> >> > >
> >> http://svn.apache.org/viewvc/lucene.net/trunk/build/scripts/All/Lucene.Net.nuspec?rev=1391857&r1=1391856&r2=1391857&view=diff
> >> > >
> >> > >
> >> ==============================================================================
> >> > > --- lucene.net/trunk/build/scripts/All/Lucene.Net.nuspec (original)
> >> > > +++ lucene.net/trunk/build/scripts/All/Lucene.Net.nuspec Sat Sep 29
18
> >> :38:27
> >> > > 2012
> >> > > @@ -26,7 +26,7 @@
> >> > > <owners>The Apache Software Foundation</owners>
> >> > > <iconUrl>
> >> > >
> >> http://incubator.apache.org/lucene.net/media/lucene-net-ico-128x128.png
> >> > > </iconUrl>
> >> > > <licenseUrl>http://www.apache.org/licenses/LICENSE-2.0.html
> >> > > </licenseUrl>
> >> > > - <projectUrl>http://incubator.apache.org/lucene.net/</projectUrl>
> >> > > + <projectUrl>http://lucenenet.apache.org/</projectUrl>
> >> > > <requireLicenseAcceptance>false</requireLicenseAcceptance>
> >> > > <description>Lucene.Net is a port of the Lucene search engine
> >> > > library, written in C# and targeted at .NET runtime users.
> >> > >
> >> > >
> >> > > Modified:
> >> lucene.net/trunk/build/scripts/Contrib/Lucene.Net.Contrib.nuspec
> >> > > URL:
> >> > >
> >> http://svn.apache.org/viewvc/lucene.net/trunk/build/scripts/Contrib/Lucene.Net.Contrib.nuspec?rev=1391857&r1=1391856&r2=1391857&view=diff
> >> > >
> >> > >
> >> ==============================================================================
> >> > > ---
> >> lucene.net/trunk/build/scripts/Contrib/Lucene.Net.Contrib.nuspec(original)
> >> > > +++ lucene.net/trunk/build/scripts/Contrib/Lucene.Net.Contrib.nuspecSat
> >> > > Sep 29 18:38:27 2012
> >> > > @@ -26,7 +26,7 @@
> >> > > <owners>The Apache Software Foundation</owners>
> >> > > <iconUrl>
> >> > >
> >> http://incubator.apache.org/lucene.net/media/lucene-net-ico-128x128.png
> >> > > </iconUrl>
> >> > > <licenseUrl>http://www.apache.org/licenses/LICENSE-2.0.html
> >> > > </licenseUrl>
> >> > > - <projectUrl>http://incubator.apache.org/lucene.net/</projectUrl>
> >> > > + <projectUrl>http://lucenenet.apache.org/</projectUrl>
> >> > > <requireLicenseAcceptance>false</requireLicenseAcceptance>
> >> > > <description>Lucene.Net is a port of the Lucene search engine
> >> > > library, written in C# and targeted at .NET runtime users.
> >> > >
> >> > > @@ -55,8 +55,6 @@
> >> > > <file
> >> > >
> >> src="..\..\bin\contrib\SimpleFacetedSearch\Release\**\Lucene.Net.Contrib.SimpleFacetedSearch.XML"
> >> > > target="lib" />
> >> > > <file
> >> > >
> >> src="..\..\bin\contrib\Snowball\Release\**\Lucene.Net.Contrib.Snowball.dll"
> >> > > target="lib" />
> >> > > <file
> >> > >
> >> src="..\..\bin\contrib\Snowball\Release\**\Lucene.Net.Contrib.Snowball.XML"
> >> > > target="lib" />
> >> > > - <file
> >> > >
> >> src="..\..\bin\contrib\Spatial\Release\**\Lucene.Net.Contrib.Spatial.dll"
> >> > > target="lib" />
> >> > > - <file
> >> > >
> >> src="..\..\bin\contrib\Spatial\Release\**\Lucene.Net.Contrib.Spatial.XML"
> >> > > target="lib" />
> >> > > <file
> >> > >
> >> src="..\..\bin\contrib\SpellChecker\Release\**\Lucene.Net.Contrib.SpellChecker.dll"
> >> > > target="lib" />
> >> > > <file
> >> > >
> >> src="..\..\bin\contrib\SpellChecker\Release\**\Lucene.Net.Contrib.SpellChecker.XML"
> >> > > target="lib" />
> >> > > </files>
> >> > >
> >> > > Modified: lucene.net/trunk/build/scripts/Core/Lucene.Net.Core.nuspec
> >> > > URL:
> >> > >
> >> http://svn.apache.org/viewvc/lucene.net/trunk/build/scripts/Core/Lucene.Net.Core.nuspec?rev=1391857&r1=1391856&r2=1391857&view=diff
> >> > >
> >> > >
> >> ==============================================================================
> >> > > --- lucene.net/trunk/build/scripts/Core/Lucene.Net.Core.nuspec(original)
> >> > > +++ lucene.net/trunk/build/scripts/Core/Lucene.Net.Core.nuspec Sat
> >> Sep 29
> >> > > 18:38:27 2012
> >> > > @@ -26,7 +26,7 @@
> >> > > <owners>The Apache Software Foundation</owners>
> >> > > <iconUrl>
> >> > >
> >> http://incubator.apache.org/lucene.net/media/lucene-net-ico-128x128.png
> >> > > </iconUrl>
> >> > > <licenseUrl>http://www.apache.org/licenses/LICENSE-2.0.html
> >> > > </licenseUrl>
> >> > > - <projectUrl>http://incubator.apache.org/lucene.net/</projectUrl>
> >> > > + <projectUrl>http://lucenenet.apache.org/</projectUrl>
> >> > > <requireLicenseAcceptance>false</requireLicenseAcceptance>
> >> > > <description>Lucene.Net is a port of the Lucene search engine
> >> > > library, written in C# and targeted at .NET runtime users.
> >> > >
> >> > >
> >> > > Modified:
> >> > >
> >> lucene.net/trunk/build/scripts/Spatial.NTS/Lucene.Net.Spatial.NTS.nuspec
> >> > > URL:
> >> > >
> >> http://svn.apache.org/viewvc/lucene.net/trunk/build/scripts/Spatial.NTS/Lucene.Net.Spatial.NTS.nuspec?rev=1391857&r1=1391856&r2=1391857&view=diff
> >> > >
> >> > >
> >> ==============================================================================
> >> > > ---
> >> > >
> >> lucene.net/trunk/build/scripts/Spatial.NTS/Lucene.Net.Spatial.NTS.nuspec(original)
> >> > > +++
> >> > >
> >> lucene.net/trunk/build/scripts/Spatial.NTS/Lucene.Net.Spatial.NTS.nuspecSatSep
29
> >> > > 18:38:27 2012
> >> > > @@ -21,27 +21,23 @@
> >> > > <metadata>
> >> > > <id>Lucene.Net.Spatial.NTS</id>
> >> > > <version>$version$</version>
> >> > > - <title>Lucene.Net Spatial NTS Library</title>
> >> > > + <title>Lucene.Net Spatial Contrib with NTS support</title>
> >> > > <authors>Lucene.Net Community</authors>
> >> > > <owners>The Apache Software Foundation</owners>
> >> > > <iconUrl>
> >> > >
> >> http://incubator.apache.org/lucene.net/media/lucene-net-ico-128x128.png
> >> > > </iconUrl>
> >> > > <licenseUrl>http://www.apache.org/licenses/LICENSE-2.0.html
> >> > > </licenseUrl>
> >> > > - <projectUrl>http://incubator.apache.org/lucene.net/</projectUrl>
> >> > > + <projectUrl>http://lucenenet.apache.org/</projectUrl>
> >> > > <requireLicenseAcceptance>false</requireLicenseAcceptance>
> >> > > - <description>Lucene.Net is a port of the Lucene search engine
> >> > > library, written in C# and targeted at .NET runtime users.
> >> > > -
> >> > > -**This package contains only the Spatial NTS Contrib Lucene.Net
> >> > > assembly.</description>
> >> > > + <description>Adds support for advanced geo-spatial searches
to
> >> > > Lucene.Net 3.0.3, including polygon searches and other WKT shapes.
> >> Bundled
> >> > > with NetTopologySuite for performing advanced geometry
> >> > > operations.</description>
> >> > > <summary>Lucene.Net is a port of the Lucene search engine library,
> >> > > written in C# and targeted at .NET runtime users.</summary>
> >> > > - <tags>lucene.net core search information retrieval lucene
> >> > > apache</tags>
> >> > > + <tags>lucene.net core search information retrieval lucene
apache
> >> > > spatial spatial4n spatial4j nts nettopologysuite WKT polygon</tags>
> >> > > <dependencies>
> >> > > <dependency id="Lucene.Net" version="3.0.3" />
> >> > > - <dependency id="NetTopologySuite" version="1.12.0" />
> >> > > - <dependency id="GeoAPI" version="1.6.0" />
> >> > > + <dependency id="Spatial4n.Core.NTS" version="0.3" />
> >> > > </dependencies>
> >> > > </metadata>
> >> > > <files>
> >> > > <file
> >> > >
> >> src="..\..\bin\contrib\Spatial.NTS\Release\**\Lucene.Net.Contrib.Spatial.NTS.dll"
> >> > > target="lib" />
> >> > > <file
> >> > >
> >> src="..\..\bin\contrib\Spatial.NTS\Release\**\Lucene.Net.Contrib.Spatial.NTS.XML"
> >> > > target="lib" />
> >> > > </files>
> >> > > -
> >> > > </package>
> >> > > \ No newline at end of file
> >> > >
> >> > > Copied:
> >> lucene.net/trunk/build/scripts/Spatial/Lucene.Net.Spatial.nuspec(fromr1391728,
> >> > > lucene.net/trunk/build/scripts/Core/Lucene.Net.Core.nuspec)
> >> > > URL:
> >> > >
> >> http://svn.apache.org/viewvc/lucene.net/trunk/build/scripts/Spatial/Lucene.Net.Spatial.nuspec?p2=lucene.net/trunk/build/scripts/Spatial/Lucene.Net.Spatial.nuspec&p1=lucene.net/trunk/build/scripts/Core/Lucene.Net.Core.nuspec&r1=1391728&r2=1391857&rev=1391857&view=diff
> >> > >
> >> > >
> >> ==============================================================================
> >> > > --- lucene.net/trunk/build/scripts/Core/Lucene.Net.Core.nuspec(original)
> >> > > +++ lucene.net/trunk/build/scripts/Spatial/Lucene.Net.Spatial.nuspecSat
> >> > > Sep 29 18:38:27 2012
> >> > > @@ -19,24 +19,25 @@
> >> > > -->
> >> > > <package xmlns="
> >> http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd
> >> > > ">
> >> > > <metadata>
> >> > > - <id>Lucene.Net.Core</id>
> >> > > + <id>Lucene.Net.Spatial</id>
> >> > > <version>$version$</version>
> >> > > - <title>Lucene.Net Core</title>
> >> > > + <title>Lucene.Net Spatial Contrib</title>
> >> > > <authors>Lucene.Net Community</authors>
> >> > > <owners>The Apache Software Foundation</owners>
> >> > > <iconUrl>
> >> > >
> >> http://incubator.apache.org/lucene.net/media/lucene-net-ico-128x128.png
> >> > > </iconUrl>
> >> > > <licenseUrl>http://www.apache.org/licenses/LICENSE-2.0.html
> >> > > </licenseUrl>
> >> > > - <projectUrl>http://incubator.apache.org/lucene.net/</projectUrl>
> >> > > + <projectUrl>http://lucenenet.apache.org/</projectUrl>
> >> > > <requireLicenseAcceptance>false</requireLicenseAcceptance>
> >> > > - <description>Lucene.Net is a port of the Lucene search engine
> >> > > library, written in C# and targeted at .NET runtime users.
> >> > > -
> >> > > -This package contains only the core Lucene.Net assembly.</description>
> >> > > + <description>Adds support for geo-spatial searches to Lucene.Net
> >> > > 3.0.3</description>
> >> > > <summary>Lucene.Net is a port of the Lucene search engine library,
> >> > > written in C# and targeted at .NET runtime users.</summary>
> >> > > - <tags>lucene.net core search information retrieval lucene
> >> > > apache</tags>
> >> > > + <tags>lucene.net core search information retrieval lucene
apache
> >> > > spatial spatial4n spatial4j</tags>
> >> > > + <dependencies>
> >> > > + <dependency id="Lucene.Net" version="3.0.3" />
> >> > > + <dependency id="Spatial4n.Core" version="0.3" />
> >> > > + </dependencies>
> >> > > </metadata>
> >> > > <files>
> >> > > - <file src="..\..\bin\core\Release\**\Lucene.Net.dll" target="lib"
> >> > > />
> >> > > - <file src="..\..\bin\core\Release\**\Lucene.Net.XML" target="lib"
> >> > > />
> >> > > + <file
> >> > >
> >> src="..\..\bin\contrib\Spatial\Release\**\Lucene.Net.Contrib.Spatial.dll"
> >> > > target="lib" />
> >> > > + <file
> >> > >
> >> src="..\..\bin\contrib\Spatial\Release\**\Lucene.Net.Contrib.Spatial.XML"
> >> > > target="lib" />
> >> > > </files>
> >> > > -
> >> > > </package>
> >> > > \ No newline at end of file
> >> > >
> >> > >
> >> > >
> >> > >
> >> 		 	   		  
Mime
View raw message