lucenenet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Currens (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENENET-493) Make lucene.net culture insensitive (like the java version)
Date Mon, 11 Jun 2012 23:34:43 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293189#comment-13293189
] 

Christopher Currens commented on LUCENENET-493:
-----------------------------------------------

This is rather annoying, actually.  Java has tests for different cultures wired into the test
suite.  Interestingly enough, so do we, but because of the differences between JUnit and NUnit
(namely attribute based test discovery), we can't override the test running implementation
in the same way java does.  So, the code we've ported for testing cultures does not work...period.
 NUnit supports changing the cultures via attributes, but only a single culture.  MbUnit allows
multiple cultures and will run the test each time in that culture.  We should find a workaround.
                
> Make lucene.net culture insensitive (like the java version)
> -----------------------------------------------------------
>
>                 Key: LUCENENET-493
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-493
>             Project: Lucene.Net
>          Issue Type: Bug
>          Components: Lucene.Net Core, Lucene.Net Test
>    Affects Versions: Lucene.Net 3.0.3
>            Reporter: Luc Vanlerberghe
>              Labels: patch
>             Fix For: Lucene.Net 3.0.3
>
>         Attachments: Lucenenet-493.patch
>
>
> In Java, conversion of the basic types to and from strings is locale (culture) independent.
For localized input/output one needs to use the classes in the java.text package.
> In .Net, conversion of the basic types to and from strings depends on the default Culture.
 Otherwise you have to specify CultureInfo.InvariantCulture explicitly.
> Some of the testcases in lucene.net fail if they are not run on a machine with culture
set to US.
> In the current version of lucene.net there are patches here and there that try to correct
for some specific cases by using string replacement (like  System.Double.Parse(s.Replace(".",
CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator)), but that seems really ugly.
> I submit a patch here that removes the old workarounds and replaces them by calls to
classes in the Lucene.Net.Support namespace that try to handle the conversions in a compatible
way.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message